苹果FFT给出的结果不一致

Question

苹果FFT给出的结果不一致

4

我使用本地Apple类实现了FFT算法。我直接从他们的网站上获取了代码：

https://developer.apple.com/documentation/accelerate/vdsp/fast_fourier_transforms/finding_the_component_frequencies_in_a_composite_sine_wave

然而，每次运行代码时，它都提供不同的结果。我创建了一个单元测试，重复运行代码并比较结果，如果单元测试失败，则说明结果不同。我唯一的猜测是这是一个内存问题。这是我想象中唯一可能导致结果每次不同的方式。

import Foundation
import Accelerate

class AppleFFT{
    var windowSize = 512
    var n = vDSP_Length(512)
    var halfN = Int(512 / 2)
    var fftSetUp : FFTSetup?
    var log2n : vDSP_Length?
    init(windowSize: Int){
        self.windowSize = windowSize 
        n = vDSP_Length(windowSize)
        halfN = Int(n / 2)
        initialize()
    }
    private init(){
        initialize()
    }
    func initialize(){
        log2n = vDSP_Length(log2(Float(n)))
        if log2n == nil { return }
        fftSetUp = vDSP_create_fftsetup(log2n!, FFTRadix(kFFTRadix2))

    }
    func process(signal : [Float], n: vDSP_Length) ->DSPSplitComplex{
        let window = vDSP.window(ofType: Float.self,
                                 usingSequence: .hanningDenormalized,
                                 count: Int(n), 
                                 isHalfWindow: false)

        let signal2 = vDSP.multiply(signal, window)
        let observed: [DSPComplex] = stride(from: 0, to: Int(n), by: 2).map {
            return DSPComplex(real: signal[$0],
                              imag: signal[$0.advanced(by: 1)])
        }

        var forwardInputReal = [Float](repeating: 0, count: halfN)
        var forwardInputImag = [Float](repeating: 0, count: halfN)

        var forwardInput = DSPSplitComplex(realp: &forwardInputReal,
                                           imagp: &forwardInputImag)

        vDSP_ctoz(observed, 2,
                  &forwardInput, 1,
                  vDSP_Length(halfN))

        //Create some empty arrays we can put data into
        var forwardOutputReal = [Float](repeating: 0, count: halfN)
        var forwardOutputImag = [Float](repeating: 0, count: halfN)
        var forwardOutput = DSPSplitComplex(realp: &forwardOutputReal,
                                            imagp: &forwardOutputImag)

        //Perform actual fft, placing results in forwardOutput
        vDSP_fft_zrop(fftSetUp!,
                      &forwardInput, 1,
                      &forwardOutput, 1,
                      log2n!,
                      FFTDirection(kFFTDirection_Forward))

        //Do cheap analysis to figure out original frequencies
        let componentFrequencies = forwardOutputImag.enumerated().filter {
            $0.element < -1
        }.map {
            return $0.offset
        }
        return forwardOutput
    }
}

import XCTest
import Accelerate

class testAppleFFT: XCTestCase {

    func testFFTConsistency(){
        let signal = genSignalWith(frequencies:[100, 500], numSamples: 512, sampleRate: 44100)
        let fft = AppleFFT(windowSize: 512)
        let complex1 = fft.process(signal: signal , n: 512)
        for i in 0..<10{
            print("i = \(i)")
            let complex2 = fft.process(signal: signal, n: 512)
            var complex1realp = complex1.realp
            var complex1imagp = complex1.imagp
            var complex2realp = complex2.realp
            var complex2imagp = complex2.imagp
            for j in 0..<512 {
                let r1 = complex1realp.pointee
                let i1 = complex1imagp.pointee
                let r2 = complex2realp.pointee
                let i2 = complex2imagp.pointee
                XCTAssert(abs(r1 - r2) < 0.00001)
                XCTAssert(abs(i1 - i2) < 0.00001)
                if !(abs(r1 - r2) < 0.00001){
                    print(" error: i: \(i) j: \(j) r1: \(r1) r2: \(r2)")
                }
                if !(abs(i1 - i2) < 0.00001){
                    print(" error: index: \(i) i1: \(i1) i2: \(i2)")
                }
                complex1realp = complex1realp.advanced(by: 1)
                complex1imagp = complex1imagp.advanced(by: 1)
                complex2realp = complex2realp.advanced(by: 1)
                complex2imagp = complex2imagp.advanced(by: 1)

            }    
        }
    }
    func genSignalWith(frequencies: [Float], numSamples: Int, sampleRate: Float, amplitudes: [Float] = []) -> [Float]{
        var sig : [Float] = []
        for t in 0..<numSamples{
            var sum : Float = 0.0
            for i in 0..<frequencies.count{
                let f = frequencies[i]
                var a : Float = 1.0
                if(amplitudes.count > i){
                     a = amplitudes[i] 
                }
                let thisValue = sin(Float(t) / sampleRate * 2 * .pi * f)
                sum += thisValue
            }
            sig.append(sum)
        }
        return sig
    }
}

- dmann200

1

是的，你可能正在读取未初始化的内存。尝试启用AddressSanitizer编译：https://clang.llvm.org/docs/AddressSanitizer.html - Cris Luengo

1个回答

网页内容由stack overflow 提供, 点击上面的

可以查看英文原文，
原文链接

- Stephen Canon · Accepted Answer

这是：

var forwardInput = DSPSplitComplex(realp: &forwardInputReal,
                                   imagp: &forwardInputImag)
vDSP_ctoz(observed, 2, &forwardInput, 1, vDSP_Length(halfN))

它不能按照你所期望的方式运行。如果你来自C或C++背景，那么这个问题有点微妙。Swift中的数组不像C或C++中的数组，特别是它们在内存中没有固定地址。它们是Swift可能选择移动的对象。当你在Swift中工作时，这很好，但有时候在需要与C函数交互（尤其是C类型想要跨函数调用保持指针时）会引起痛苦，正如你所注意到的。

当你调用DSPSplitComplex(realp: &forwardInputReal, ...)时，&隐含地创建了一个UnsafeMutablePointer<Float>指向forwardInputReal的内存，但该指针仅在调用init期间有效。当你将forwardInput传递给vDSP_ctoz时，指针已经超出范围，不再有效，因此你正在调用未定义的行为。特别地，编译器可以假设调用vDSP_ctoz不会修改forwardInputReal或forwardInputImag的内容，因为该函数未接收到它们内容的有效指针。

解决此问题的最佳方法是更加明确：

forwardInputReal.withUnsafeMutableBufferPointer { r in
  forwardInputImag.withUnsafeMutableBufferPointer { i in
    var splitComplex = DSPSplitComplex(realp: r.baseAddress!, imagp: i.baseAddress!)
     vDSP_ctoz(observed, 2, &splitComplex, 1, vDSP_Length(halfN))
  }
}
// forwardInput[Real,Imag] now contain the de-interleaved data.
// splitComplex is out-of-scope and cannot be used, so the invalid pointers
// are discarded.

有一些事情可以让这个过程更容易。

首先，Swift编译器即将进行更改，以便为您诊断此错误。

其次，我们可以将我展示的小技巧包装成一些方便的函数：

/// De-interleave the real and imaginary parts of a complex buffer into two
/// new Float arrays.
func ctoz<T>(_ data: T) -> (real: [Float], imag: [Float])
where T: AccelerateBuffer, T.Element == DSPComplex {
  var imag = [Float]()
  let real = [Float](unsafeUninitializedCapacity: data.count) { r, n in
    imag = [Float](unsafeUninitializedCapacity: data.count) { i, n in
      ctoz(data, real: &r, imag: &i)
      n = data.count
    }
    n = data.count
  }
  return (real, imag)
}

/// De-interleave the real and imaginary parts of a complex buffer into two
/// caller-provided Float buffers.
///
/// - Precondition: data, real, and imag must all have the same length.
func ctoz<T, U, V>(_ data: T, real: inout U, imag: inout V)
where T: AccelerateBuffer, T.Element == DSPComplex,
      U: AccelerateMutableBuffer, U.Element == Float,
      V: AccelerateMutableBuffer, V.Element == Float
{
  precondition(data.count == real.count && data.count == imag.count)
  real.withUnsafeMutableBufferPointer { r in
    imag.withUnsafeMutableBufferPointer { i in
      var split = DSPSplitComplex(realp: r.baseAddress!, imagp: i.baseAddress!)
      data.withUnsafeBufferPointer { d in
        vDSP_ctoz(d.baseAddress!, 2, &split, 1, vDSP_Length(data.count))
      }
    }
  }
}

有了这些定义的便利函数，您只需要执行以下操作：

var forwardInputReal = [Float](repeating: 0, count: halfN)
var forwardInputImag = [Float](repeating: 0, count: halfN)
ctoz(observed, real: &forwardInputReal, imag: &forwardInputImag)

或者甚至：

let (forwardInputReal, forwardInputImag) = ctoz(data)

我将与vDSP团队交流，看看是否可以在未来的框架中添加类似的功能，这样您就不需要自己编写了。