第一次发帖，长期阅读 :)
我刚刚编写了我的第一个谷歌应用脚本，用于汇总来自14个电子表格的信息，每个表格具有2-30个工作表，并将其放入单个报告电子表格中。
脚本运行得很好，它检查单个列是否有数据，如果找到，则获取电子表格名称、工作表名称、该行的第一列数据以及检查列中的数据，并将其作为数据的子数组添加到数组中。
然后，它计算子数组的面积并将数据写入报告文件（即脚本运行的地方）。
我唯一的问题是脚本运行大约需要2分钟。
我想知道自己的方法是否低效，并希望有人能够审查脚本并让我知道是否犯了一些错误？
以下是脚本：
/**
* Retrieves all the rows in the active spreadsheet that contain data and logs the
* values for each row.
* For more information on using the Spreadsheet API, see
* https://developers.google.com/apps-script/service_spreadsheet
*/
function getFaults() {
/** opens each spreadsheet for Liddon and examines the "Report/Replace" column "F"
if there is data there then get the
[Sheetname], [fault area (column "A" row relative to the "F" field found)] and the ["F" field data]
**/
var reportsheet = SpreadsheetApp.getActiveSheet();
var reportdata = []
var reportrow = 0
var liddonblocks = [
"1APshQevK7iZxhP7--zmtuM3K6dPTgTZjmNarQ6CEsV4", "1riCQMOa38jo4nCD4qjW1BFZKk5xpXFZiCXHzXpiYKIU", "1NTKXmted1-U12MiqvCGRuYBdhPy1_eLiPn7v8_oVKFE", "1RKOJUNNi5TAg5dETZDtLjZOkUSheuguzmtdPelMclMI",
"1b5-fzCp0wzW8llpUc_6xi1iTFzsapZh9ASSFgDYt4WU", "1qJtY37K0zwoJcz7LdyHhWgkypRMP9LabBchNLM4Fgow", "1yvf4W8-SkfTH-n-PdDNQeyEDEz-shzTe-Id57S_YB2M", "1ETZc1xeNGXU6ipb1XQiD8SiIyRXzZtiJfS4AClKroJk",
"1tJ5u3Hv0uz-n2cdw-QYixKnuMG9skvrUbz1UROhIm34", "1DjhmIdD0GrPxR-fv7pCPkIwIyfai5BHsK9GhT-Hcs3k", "15w39NZZIacD1OfiTWG1E3HmOhV0B_e2Jsuan_ySwf2Q" , "1cK2HBLEftYOZEkCcxs1TX1PxcJRiKTZpQrcsOfE4B1s",
"16W_bfMKk98wkLpEmm2Q68Ta_SrCA8EBarQyGF2yfm18","1_Z_tgF5UAfq3fxPsDEe40z2GZSehhL-u4hEuVszrbn8" ]
// loop through the spreadsheets
for (block = 0; block < liddonblocks.length; block++) {
//open the spreadsheet using the index from the liddonblocks list
var ss = SpreadsheetApp.openById(liddonblocks[block]);
//get all of the sheets within the spreadsheet
var sheets = ss.getSheets();
//loop through each sheet in each spreadsheet using the length of the number of sheets in the spreadsheet as the index
for (var sheetnum = 0; sheetnum < sheets.length; sheetnum++) {
//get an array of all data in the sheet
//assigns array in the form of: [[area, fault], [Bedroom, Broken Bed], [Bathroom, ]]
//where each sub-array is a row of data starting at row 1 eg: [[row1-col1, row1-col2...],[row2-col1, row2-col2...]...]
data = sheets[sheetnum].getDataRange().getValues();
//get the text name of the sheet
name = sheets[sheetnum].getSheetName();
// iterate over the data set and look for values in the 5th column, starting at row 7 to exclude the headers.
// this is the column named "Report / Replace "
for (var count = 7; count < data.length; count++) {
if (data[count][5] != "" && data[count][5] != 0) {
//if there is data in the 5th column of the row then append the following data to the reportdata array and a sub-array
// [ sheetname, columnA, columnF ]
reportdata[reportrow] = [ ss.getName(), name, data[count][0], data[count][5]]
//increment the reportcount variable so any further hits on data in column 5 are created as sequentail sub-arrays in the reportdata array.
reportrow++
}
}
}
}
//write the contents of reportdata to the console
var range = reportsheet.getRange(2,1,reportrow,reportdata[0].length);
range.setValues(reportdata);
}
/**
* Adds a custom menu to the active spreadsheet, containing a single menu item
* for invoking the readRows() function specified above.
* The onOpen() function, when defined, is automatically invoked whenever the
* spreadsheet is opened.
* For more information on using the Spreadsheet API, see
* https://developers.google.com/apps-script/service_spreadsheet
*/
function onOpen() {
var spreadsheet = SpreadsheetApp.getActiveSpreadsheet();
var entries = [{
name : "Update Report",
functionName : "getFaults"
}];
spreadsheet.addMenu("Keble Scripts", entries);
};
if (data[count][5] != "" && data[count][5] != 0)可以替换成if (data[count][5])，因为""和0都是“falsy”的（参见ECMAScript Language Spec，第9.2节）。这将减少每个循环中的一个比较，并覆盖null值...但与GAS服务调用相比不太明显。 - Mogsdad