我的AngularJS双向无限滚动有什么问题?

4
我使用AngularJS为移动Web应用程序构建了无限滚动,并添加了以下附加功能:
  1. 我将其构建为双向的
  2. 由于这是一个移动Web应用程序,我希望卸载不在视图中的内容以避免内存问题
这是jsfiddle链接
现在,我有几个问题,我还需要进行一些小型代码审查:
  1. 我不熟悉promises,但似乎then()$digest之前执行。 因此,我需要使用$timeout延迟我的代码。 对我而言,这是有问题的迹象。 我想删除第85行和第98行上的$timeout。 第85行上的$timeout有点“hacky”,我需要确保它在 then() 之后执行ms,否则它不起作用,我不知道为什么。
  2. 我想知道从指令调用$scope方法是否被认为是“良好实践”。 在我的代码中,我正在从我的指令中调用$scope.init(value)
  3. 仅仅为了使用position()而包含jQuery很有趣。 我应该使用带有执行 $ .position()的函数的服务吗?
我知道这些可能是单独的问题,但它们确实与我的代码相关。
对于那些不想单击jsfiddle链接的人,这里是代码: HTML:
<div id="fixed" scroll-watch="4" scroll-up="loadTop()" scroll-down="loadBottom()">
    <ul>
        <li data-id="{{i.id}}" ng-repeat="i in items" ng-class="calculateType(i.id)">{{i.id}}</li>
    </ul>
</div>

JS:

function Main($scope, $timeout, $q) {
    var cleanup = 5;

    $scope.items = [];

    //This is called from the scrollWatch directive. IMO, this shouldn't be a good idea
    $scope.init = function(value) {
        var deferred = $q.defer();

        //This $timeout is used to simulate an Ajax call so I will keep it there
        $timeout(function() {
            $scope.items = [{id: +value}];

            $scope.loadTop();
            $scope.loadBottom();

            deferred.resolve();
        }, 200);

        return deferred.promise;
    };

    //This is only used to simulate different content's heights
    $scope.calculateType = function(type) {
        return 'type-' + Math.abs(type) % 4;  
    };

    $scope.loadBottom = function() {
        var deferred = $q.defer(),
            counter;

        if ($scope.items.length > 1) {
            $scope.items.splice(0, cleanup);
        }

        //This $timeout is used to simulate an Ajax call so I will keep it there
        $timeout(function() {
            counter = (($scope.items[$scope.items.length - 1]) || {id: 0}).id;

            for (var i = 1; i < 6; i++) {
                $scope.items.push({id: counter + i});
            }

            deferred.resolve();
        }, 200);

        return deferred.promise;
    };

    $scope.loadTop = function() {
        var deferred = $q.defer(),
            counter;

        //Why can't I use this here?
        //$scope.items.splice($scope.items.length-cleanup, $scope.items.length);

        //This $timeout is used to simulate an Ajax call so I will keep it there
        $timeout(function() {
            counter = (($scope.items[0]) || {id: 0}).id;

            for (var i = 1; i < 6; i++) {
                $scope.items.unshift({id: counter - i});
            }

            deferred.resolve();
        }, 200);

        return deferred.promise;
    };

    //Why is this method needs to be delayed inside the directive? I would like to call it in loadTop()
    $scope.removeBottom = function() {
        $scope.items.splice($scope.items.length-cleanup, $scope.items.length);
    };
}

angular.module('scroll', []).directive('scrollWatch', ['$timeout', function($timeout) {
    var lastScrollTop = 0;

    return function($scope, elm, attr) {
        var raw = elm[0];

        $scope.init(attr.scrollWatch).then(function() {
            //Why do I need this? It looks like the resolve is called before the $digest cycle
            $timeout(function() {
                raw.scrollTop = $('li[data-id="' + attr.scrollWatch + '"]').position().top;
            }, 300); //This value needs to be great enough so it is executed after the $scope.loadTop()'s resolve, for now, I know that I can set it to 300 but in real life app?
        });

        elm.bind('scroll', function() {
            if (raw.scrollTop > lastScrollTop && raw.scrollTop + raw.offsetHeight >= raw.scrollHeight) {
                $scope.$apply(attr.scrollDown);
            } else if (raw.scrollTop < lastScrollTop && raw.scrollTop === 0) {
                var scrollHeight = raw.scrollHeight;

                $scope.$apply(attr.scrollUp).then(function() {
                    //Why do I need this? It looks like the resolve is called before the $digest cycle
                    $timeout(function() {
                        raw.scrollTop = raw.scrollHeight - scrollHeight;

                        //I would like to move this in the $scope.loadTop()
                        $scope.removeBottom();
                    });
                });
            }

            lastScrollTop = raw.scrollTop;
        });
    };
}]);

谢谢你。

在解决承诺之前,请自行调用$scope.$digest:http://jsfiddle.net/D5fT3/6/。我认为$timeout在回调执行后调用$digest。 - Sanjo
1个回答

1

网页内容由stack overflow 提供, 点击上面的
可以查看英文原文,
原文链接