我有一个问题,需要将控制器中的数据传递给class <<self
下的方法。但是,出现了wrong number of arguments (0 for 1)
错误,而且我无法弄清楚为什么会出错,也不知道该如何解决。
我的app/controllers/emails_controller代码如下:
def create
# Make a new email
@email = Email.new(email_params)
# For the email, store the user id as the id of the user logged in
@email.user_id = session[:user_id]
# store the user id
@user = session[:user_id]
# if the email has saved in the database
if @email.save
email_to_name = @email.to_name
# split the email addresses selected by the ";"
@emails = (email_params[:to]).split("; ")
# for each email address selected do the following
@emails.each do |emailaddress|
# the "to" section of the email is to one email address
@email.to = emailaddress
# find who to address the email to using the Contact model
@email.to_name = address_email_to(email_to_name, @email.prefix, emailaddress)
# find the contact the user wants to email
contact = Contact.find_by_email(emailaddress).id
# generate a unsubscribe token
@unsubscribe = Rails.application.message_verifier(:unsubscribe).generate(contact)
# PASS THE ACCOUNT ID TO THE SMTP SETTINGS METHOD IN MY MAILER
UserEmails.smtp_settings(@email.account_id)
# send the email
UserEmails.send_email(@email, @unsubscribe, @email.logo).deliver_now
end
# show the email
redirect_to @email, notice: 'Email was successfully created.'
# if not saved
else
# go back to the new email page
redirect 'new'
end
end
private
def email_params
res = params.require(:email).permit(:account_id, :cc, :bcc, :subject, :greeting, :to_name, :prefix, :message, :from_name, :logo, to: [])
res[:to] = res[:to].join('; ')
res
end
我的app/mailers/user_emails.rb是:
class UserEmails < ApplicationMailer
if Rails.env.development?
class <<self
def smtp_settings(account)
options = YAML.load_file("#{Rails.root}/config/mailers.yml")[Rails.env]['send_email']
@@smtp_settings = {
:address => 'smtp.gmail.com',
:port => 587,
:domain => 'my-domain.com',
:authentication => 'plain',
# FIND THE USER-NAME IN THE ACCOUNT MODEL
:user_name => Account.find_by_id(account).email,
:password => 'my password',
}
end
end
end
def send_email(email, unsubscribe, logo)
@url = 'http://localhost:3000/users/login'
@email = email
@unsubscribe = unsubscribe
@logo = logo
mail(from: "#{@email.from_name} <#{@email.account.email}>", to: @email.to, cc: @email.cc, bcc: @email.bcc, subject: @email.subject, message: @email.message)
end
end
日志记录如下:
Started POST "/emails" for ::1 at 2016-09-09 11:11:15 +0100
Processing by EmailsController#create as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"rCvqJpUNAMker3u6R5sOLjP317oN33t7LSAbJoul1nNkfRt/WwJYT+4vS/fmNW37/XzSOREqafIj/Dqf1k330Q==", "email"=>{"from_name"=>"Ben Smith", "account_id"=>"30", "to"=>["email@gmail.com", ""], "logo"=>"", "subject"=>"", "greeting"=>"No Greeting", "to_name"=>"No Name", "prefix"=>"No", "message"=>""}, "commit"=>"Create Email"}
[1m[35m (0.0ms)[0m begin transaction
[1m[36mSQL (1.0ms)[0m [1mINSERT INTO "emails" ("account_id", "subject", "greeting", "to_name", "prefix", "message", "from_name", "logo", "to", "user_id", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)[0m [["account_id", 30], ["subject", ""], ["greeting", ""], ["to_name", "No Name"], ["prefix", "No"], ["message", ""], ["from_name", "Ben Smith"], ["logo", ""], ["to", "email@gmail.com; "], ["user_id", 2], ["created_at", "2016-09-09 10:11:15.382459"], ["updated_at", "2016-09-09 10:11:15.382459"]]
[1m[35m (205.0ms)[0m commit transaction
[1m[36mContact Load (0.0ms)[0m [1mSELECT "contacts".* FROM "contacts" WHERE "contacts"."email" = ? LIMIT 1[0m [["email", "email@gmail.com"]]
[1m[35mAccount Load (0.0ms)[0m SELECT "accounts".* FROM "accounts" WHERE "accounts"."id" = ? LIMIT 1 [["id", 30]]
UserEmails#send_email: processed outbound mail in 6.0ms
Completed 500 Internal Server Error in 234ms (ActiveRecord: 206.0ms)
ArgumentError (wrong number of arguments (0 for 1)):
app/mailers/user_emails.rb:5:in `smtp_settings'
app/mailers/user_emails.rb:34:in `send_email'
app/controllers/emails_controller.rb:58:in `block in create'
app/controllers/emails_controller.rb:46:in `each'
app/controllers/emails_controller.rb:46:in `create'
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/actionpack-4.2.6/lib/action_dispatch/middleware/templates/rescues/_source.erb (1.0ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/actionpack-4.2.6/lib/action_dispatch/middleware/templates/rescues/_trace.html.erb (4.0ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/actionpack-4.2.6/lib/action_dispatch/middleware/templates/rescues/_request_and_response.html.erb (1.0ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/actionpack-4.2.6/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout (1470.1ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/web-console-2.3.0/lib/web_console/templates/_markup.html.erb (0.0ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/web-console-2.3.0/lib/web_console/templates/_inner_console_markup.html.erb within layouts/inlined_string (1.0ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/web-console-2.3.0/lib/web_console/templates/_prompt_box_markup.html.erb within layouts/inlined_string (13.0ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/web-console-2.3.0/lib/web_console/templates/style.css.erb within layouts/inlined_string (1.0ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/web-console-2.3.0/lib/web_console/templates/console.js.erb within layouts/javascript (1370.1ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/web-console-2.3.0/lib/web_console/templates/main.js.erb within layouts/javascript (0.0ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/web-console-2.3.0/lib/web_console/templates/error_page.js.erb within layouts/javascript (0.0ms)
Rendered C:/RailsInstaller/Ruby2.2.0/lib/ruby/gems/2.2.0/gems/web-console-2.3.0/lib/web_console/templates/index.html.erb (3191.2ms)
为了背景信息,我试图每个登录用户更改SMTP服务器设置,并通过更改用户名设置来测试是否有效-如果有效,我还打算为每个用户配置其他smtp设置。例如,系统为每个用户存储地址、端口、域、身份验证用户名和密码,当用户1发送电子邮件时,这些都按照其设置进行配置,当用户2发送电子邮件时,这些都按照其设置进行配置。目前我仅将用户名包含在测试中以查看该理论是否有效。
有人能帮我解决我的问题吗?
app/mailers/user_emails.rb
的第34行,在send_email
方法中,你调用了smtp_settings
而没有传递参数。控制器可能与问题无关。 - Aleksei Matiushkinsend_mail
,而有问题的是类方法。 - Aleksei Matiushkinemail(from: "#{@email.from_name} <#{@email.account.email}>", to: email.to, cc: email.cc, bcc: email.bcc, subject: email.subject, message: email.message)
。 - Ben Smithapp/mailers/user_emails.rb
。 - ndnenkov